lkml.org 
[lkml]   [2020]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] vdpa: ifcvf: Use dma_set_mask_and_coherent to simplify code
From
Date

On 2020/11/29 下午8:54, Christophe JAILLET wrote:
> 'pci_set_dma_mask()' + 'pci_set_consistent_dma_mask()' can be replaced by
> an equivalent 'dma_set_mask_and_coherent()' which is much less verbose.
>
> While at it, fix a typo (s/confiugration/configuration)
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---


Acked-by: Jason Wang <jasowang@redhat.com>


> drivers/vdpa/ifcvf/ifcvf_main.c | 11 ++---------
> 1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c
> index 8b4028556cb6..fa1af301cf55 100644
> --- a/drivers/vdpa/ifcvf/ifcvf_main.c
> +++ b/drivers/vdpa/ifcvf/ifcvf_main.c
> @@ -417,16 +417,9 @@ static int ifcvf_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> return ret;
> }
>
> - ret = pci_set_dma_mask(pdev, DMA_BIT_MASK(64));
> + ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
> if (ret) {
> - IFCVF_ERR(pdev, "No usable DMA confiugration\n");
> - return ret;
> - }
> -
> - ret = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(64));
> - if (ret) {
> - IFCVF_ERR(pdev,
> - "No usable coherent DMA confiugration\n");
> + IFCVF_ERR(pdev, "No usable DMA configuration\n");
> return ret;
> }
>

\
 
 \ /
  Last update: 2020-11-30 03:23    [W:0.031 / U:1.860 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site