lkml.org 
[lkml]   [2020]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] scsi: storvsc: Fix error return in storvsc_probe()
Date
From: Jing Xiangfeng <jingxiangfeng@huawei.com> Sent: Thursday, November 26, 2020 7:02 PM
>
> Fix to return a error code "-ENOMEM" from the error handling case
> instead of 0.
>
> Fixes: 436ad9413353 ("scsi: storvsc: Allow only one remove lun work item to be issued per
> lun")
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
> ---
> drivers/scsi/storvsc_drv.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index 0c65fbd41035..ded00a89bfc4 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -1994,8 +1994,10 @@ static int storvsc_probe(struct hv_device *device,
> alloc_ordered_workqueue("storvsc_error_wq_%d",
> WQ_MEM_RECLAIM,
> host->host_no);
> - if (!host_dev->handle_error_wq)
> + if (!host_dev->handle_error_wq) {
> + ret = -ENOMEM;
> goto err_out2;
> + }
> INIT_WORK(&host_dev->host_scan_work, storvsc_host_scan);
> /* Register the HBA and start the scsi bus scan */
> ret = scsi_add_host(host, &device->device);
> --
> 2.22.0

Reviewed-by: Michael Kelley <mikelley@microsoft.com>

\
 
 \ /
  Last update: 2020-11-29 17:48    [W:0.063 / U:0.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site