Messages in this thread | | | Date | Sat, 28 Nov 2020 17:15:52 -0800 | From | Alexei Starovoitov <> | Subject | Re: [PATCH v2 bpf-next 01/13] bpf: x86: Factor out emission of ModR/M for *(reg + off) |
| |
On Fri, Nov 27, 2020 at 05:57:26PM +0000, Brendan Jackman wrote: > +/* Emit the ModR/M byte for addressing *(r1 + off) and r2 */ > +static void emit_modrm_dstoff(u8 **pprog, u32 r1, u32 r2, int off)
same concern as in the another patch. If you could avoid intel's puzzling names like above it will make reviewing the patch easier.
| |