lkml.org 
[lkml]   [2020]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 bpf-next 01/13] bpf: x86: Factor out emission of ModR/M for *(reg + off)
    On Fri, Nov 27, 2020 at 05:57:26PM +0000, Brendan Jackman wrote:
    > +/* Emit the ModR/M byte for addressing *(r1 + off) and r2 */
    > +static void emit_modrm_dstoff(u8 **pprog, u32 r1, u32 r2, int off)

    same concern as in the another patch. If you could avoid intel's puzzling names
    like above it will make reviewing the patch easier.

    \
     
     \ /
      Last update: 2020-11-29 02:18    [W:34.858 / U:0.680 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site