lkml.org 
[lkml]   [2020]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] nfsd: Fix kernel test robot warning
From
Date
Hello Souptick-

This looks like the same error that Coverity caught earlier this
week. AFAIK Bruce intends to address this issue with a replacement
patch:

https://lore.kernel.org/linux-nfs/20201125164738.GA7049@fieldses.org/


> On Nov 28, 2020, at 8:50 AM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
>
> Kernel test robot throws below warning -
>
>>> fs/nfsd/nfs3xdr.c:299:6: warning: variable 'err' is used
>>> uninitialized whenever 'if' condition is false
>>> [-Wsometimes-uninitialized]
> if (!v4 || !inode->i_sb->s_export_op->fetch_iversion)
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> fs/nfsd/nfs3xdr.c:304:6: note: uninitialized use occurs here
> if (err) {
> ^~~
> fs/nfsd/nfs3xdr.c:299:2: note: remove the 'if' if its condition is
> always true
> if (!v4 || !inode->i_sb->s_export_op->fetch_iversion)
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> fs/nfsd/nfs3xdr.c:293:12: note: initialize the variable 'err' to
> silence this warning
> __be32 err;
> ^
> = 0
> 1 warning generated.
>
> Initialize err = 0 to silence this warning.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
> fs/nfsd/nfs3xdr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfs3xdr.c b/fs/nfsd/nfs3xdr.c
> index abb1608..47aeaee 100644
> --- a/fs/nfsd/nfs3xdr.c
> +++ b/fs/nfsd/nfs3xdr.c
> @@ -290,7 +290,7 @@ void fill_post_wcc(struct svc_fh *fhp)
> {
> bool v4 = (fhp->fh_maxsize == NFS4_FHSIZE);
> struct inode *inode = d_inode(fhp->fh_dentry);
> - __be32 err;
> + __be32 err = 0;
>
> if (fhp->fh_post_saved)
> printk("nfsd: inode locked twice during operation.\n");
> --
> 1.9.1
>

--
Chuck Lever



\
 
 \ /
  Last update: 2020-11-28 23:39    [W:0.993 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site