Messages in this thread |  | | Date | Fri, 27 Nov 2020 08:06:19 +0000 | From | Lee Jones <> | Subject | Re: [PATCH 01/16] mfd: bcm590xx: drop of_match_ptr from of_device_id table |
| |
On Fri, 20 Nov 2020, Krzysztof Kozlowski wrote:
> The driver can match only via the DT table so the table should be always > used and the of_match_ptr does not have any sense (this also allows ACPI > matching via PRP0001, even though it is not relevant here). This fixes > compile warning (!CONFIG_OF on x86_64): > > drivers/mfd/bcm590xx.c:95:34: warning: ‘bcm590xx_of_match’ defined but not used [-Wunused-const-variable=] > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > drivers/mfd/bcm590xx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Couple of small points:
- Patch-sets, particularly large ones should have a cover letter. - Subject lines follow English grammar conventions and should start with an uppercase character.
I fixed all of these patches with respect to the above and applied them all however.
All patches applied, thanks.
-- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
|  |