Messages in this thread | | | Subject | Re: [PATCH -next] fs/ntfs: fix set but not used variable 'log_page_mask' | From | Zheng Zengkai <> | Date | Sat, 28 Nov 2020 09:29:27 +0800 |
| |
Ping... > Fixes gcc '-Wunused-but-set-variable' warning: > > fs/ntfs/logfile.c: In function ntfs_check_logfile: > fs/ntfs/logfile.c:481:21: > warning: variable log_page_mask set but not used [-Wunused-but-set-variable] > > Actually log_page_mask can be used to replace 'log_page_size - 1' as it is set. > > Signed-off-by: Zheng Zengkai <zhengzengkai@huawei.com> > --- > fs/ntfs/logfile.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ntfs/logfile.c b/fs/ntfs/logfile.c > index a0c40f1be7ac..c35fcf389369 100644 > --- a/fs/ntfs/logfile.c > +++ b/fs/ntfs/logfile.c > @@ -507,7 +507,7 @@ bool ntfs_check_logfile(struct inode *log_vi, RESTART_PAGE_HEADER **rp) > * optimize log_page_size and log_page_bits into constants. > */ > log_page_bits = ntfs_ffs(log_page_size) - 1; > - size &= ~(s64)(log_page_size - 1); > + size &= ~(s64)(log_page_mask); > /* > * Ensure the log file is big enough to store at least the two restart > * pages and the minimum number of log record pages.
| |