lkml.org 
[lkml]   [2020]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] bpf: remove trailing semicolon in macro definition
From
Date
On 11/27/20 8:27 PM, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> The macro use will already have a semicolon.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> include/trace/events/xdp.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/trace/events/xdp.h b/include/trace/events/xdp.h
> index cd24e8a59529..65ffedf8386f 100644
> --- a/include/trace/events/xdp.h
> +++ b/include/trace/events/xdp.h
> @@ -146,13 +146,13 @@ DEFINE_EVENT(xdp_redirect_template, xdp_redirect_err,
> );
>
> #define _trace_xdp_redirect(dev, xdp, to) \
> - trace_xdp_redirect(dev, xdp, NULL, 0, NULL, to);
> + trace_xdp_redirect(dev, xdp, NULL, 0, NULL, to)
>
> #define _trace_xdp_redirect_err(dev, xdp, to, err) \
> trace_xdp_redirect_err(dev, xdp, NULL, err, NULL, to);
>
> #define _trace_xdp_redirect_map(dev, xdp, to, map, index) \
> - trace_xdp_redirect(dev, xdp, to, 0, map, index);
> + trace_xdp_redirect(dev, xdp, to, 0, map, index)
>
> #define _trace_xdp_redirect_map_err(dev, xdp, to, map, index, err) \
> trace_xdp_redirect_err(dev, xdp, to, err, map, index);
>

This looks random, why those but not other locations ?

Thanks,
Daniel

\
 
 \ /
  Last update: 2020-11-28 01:59    [W:0.037 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site