lkml.org 
[lkml]   [2020]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] NFC:Fix Warning: Comparison to bool
On Thu, 26 Nov 2020 15:15:42 +0800 Runzhe Wang wrote:
> This patch uses the shdlc->rnr variable as a judgment condition of
> statement, rather than compares with bool.
>
> Signed-off-by: Runzhe Wang <xia1@linux.alibaba.com>
> Reported-by: Abaci <abaci@linux.alibaba.com>

"Fix Warning" sounds like you're addressing a real compiler warning,
please use a more suitable subject if the warning in question is from
your own tool. Like "nfc: refactor unnecessary comparison to bool".

> diff --git a/net/nfc/hci/llc_shdlc.c b/net/nfc/hci/llc_shdlc.c
> index 0eb4ddc..f178a42 100644
> --- a/net/nfc/hci/llc_shdlc.c
> +++ b/net/nfc/hci/llc_shdlc.c
> @@ -319,7 +319,7 @@ static void llc_shdlc_rcv_s_frame(struct llc_shdlc *shdlc,
> switch (s_frame_type) {
> case S_FRAME_RR:
> llc_shdlc_rcv_ack(shdlc, nr);
> - if (shdlc->rnr == true) { /* see SHDLC 10.7.7 */
> + if (shdlc->rnr) { /* see SHDLC 10.7.7 */

rnr is a bool, this is perfectly legal, there are also comparisons to
false which you don't fix, and nobody has touched this driver in 8
years so polishing this code is not exactly worth the effort.

I'm not applying this patch, sorry.

> shdlc->rnr = false;
> if (shdlc->send_q.qlen == 0) {
> skb = llc_shdlc_alloc_skb(shdlc, 0);

\
 
 \ /
  Last update: 2020-11-28 00:02    [W:0.364 / U:0.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site