lkml.org 
[lkml]   [2020]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 1/5] memory: renesas-rpc-if: Return correct value to the caller of rpcif_manual_xfer()
    On Thu 2020-11-26 19:11:42, Lad Prabhakar wrote:
    > In the error path of rpcif_manual_xfer() the value of ret is overwritten
    > by value returned by reset_control_reset() function and thus returning
    > incorrect value to the caller.
    >
    > This patch makes sure the correct value is returned to the caller of
    > rpcif_manual_xfer() by dropping the overwrite of ret in error path.
    > Also now we ignore the value returned by reset_control_reset() in the
    > error path and instead print a error message when it fails.
    >
    > Fixes: ca7d8b980b67f ("memory: add Renesas RPC-IF driver")
    > Reported-by: Pavel Machek <pavel@denx.de>
    > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
    > Cc: stable@vger.kernel.org
    > Reviewed-by: Sergei Shtylyov <sergei.shtylyov@gmail.com>

    Reviewed-by: Pavel Machek (CIP) <pavel@denx.de>

    --
    DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
    HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2020-11-27 23:45    [W:2.747 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site