Messages in this thread | | | Date | Fri, 27 Nov 2020 16:43:44 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH 1/1] perf diff: fix error return value in __cmd_diff() |
| |
On Tue, Nov 24, 2020 at 06:36:52PM +0800, Zhen Lei wrote: > An appropriate return value should be set on the failed path. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Acked-by: Jiri Olsa <jolsa@redhat.com>
thanks, jirka
> --- > tools/perf/builtin-diff.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c > index 584e2e1a3793..cefc71506409 100644 > --- a/tools/perf/builtin-diff.c > +++ b/tools/perf/builtin-diff.c > @@ -1222,8 +1222,10 @@ static int __cmd_diff(void) > if (compute == COMPUTE_STREAM) { > d->evlist_streams = evlist__create_streams( > d->session->evlist, 5); > - if (!d->evlist_streams) > + if (!d->evlist_streams) { > + ret = -ENOMEM; > goto out_delete; > + } > } > } > > -- > 2.26.0.106.g9fadedd > >
| |