lkml.org 
[lkml]   [2020]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3] arm64: dts: mediatek: Add mt8192 power domains controller
From
Date


On 19/11/2020 15:13, Enric Balletbo Serra wrote:
> Hi Weiyi,
>
> Missatge de Weiyi Lu <weiyi.lu@mediatek.com> del dia dj., 19 de nov.
> 2020 a les 14:10:
>>
>> On Thu, 2020-11-19 at 13:13 +0100, Enric Balletbo Serra wrote:
>>> Hi Weiyi,
>>>
>>> Thank you for the patch
>>>
>>> Missatge de Weiyi Lu <weiyi.lu@mediatek.com> del dia dj., 19 de nov.
>>> 2020 a les 11:48:
>>>>
>>>> Add power domains controller node for SoC mt8192
>>>>
>>>> Signed-off-by: Weiyi Lu <weiyi.lu@mediatek.com>
>>>> ---
[...]
>>>> + /* System Power Manager */
>>>> + spm: power-controller {
>>>> + compatible = "mediatek,mt8192-power-controller";
>>>> + #address-cells = <1>;
>>>> + #size-cells = <0>;
>>>> + #power-domain-cells = <1>;
>>>> +
>>>> + /* power domain of the SoC */
>>>> + audio@MT8192_POWER_DOMAIN_AUDIO {
>>>
>>> If you run the dt_bindings_check it should return some errors, as all
>>> these node names should be 'power-domain@'. Which is a bit annoying
>>> because then you will get a bunch of errors like this:
>>>
>>> [ 1.969110] debugfs: Directory 'power-domain' with parent
>>> 'pm_genpd' already present!
>>> [ 1.976997] debugfs: Directory 'power-domain' with parent
>>> 'pm_genpd' already present!
>>> [ 1.984828] debugfs: Directory 'power-domain' with parent
>>> 'pm_genpd' already present!
>>> [ 1.992657] debugfs: Directory 'power-domain' with parent
>>> 'pm_genpd' already present!
>>> [ 2.000685] debugfs: Directory 'power-domain' with parent
>>> 'pm_genpd' already present!
>>> [ 2.008566] debugfs: Directory 'power-domain' with parent
>>> 'pm_genpd' already present!
>>> [ 2.016395] debugfs: Directory 'power-domain' with parent
>>> 'pm_genpd' already present!
>>> [ 2.024221] debugfs: Directory 'power-domain' with parent
>>> 'pm_genpd' already present!
>>> [ 2.032049] debugfs: Directory 'power-domain' with parent
>>> 'pm_genpd' already present!
>>> [ 2.039874] debugfs: Directory 'power-domain' with parent
>>> 'pm_genpd' already present!
>>> [ 2.047699] debugfs: Directory 'power-domain' with parent
>>> 'pm_genpd' already present!
>>> [ 2.055524] debugfs: Directory 'power-domain' with parent
>>> 'pm_genpd' already present!
>>> [ 2.063352] debugfs: Directory 'power-domain' with parent
>>> 'pm_genpd' already present!
>>> [ 2.071176] debugfs: Directory 'power-domain' with parent
>>> 'pm_genpd' already present!
>>>
>>> But that's another problem that should be handled in debugfs system.
>>>
>>
>> Indeed...so I chose to use different name in dts to avoid problems in
>> debugfs. It does violate the naming rules.
>>
>
> But your binding will not pass (or trigger warnings) the dtb check
> then. Rob was clear that names should be generic. Proper fix is fix
> debugfs not the binding.
>

By the way, is anybody working on this debugfs issue?

Regards,
Matthias

\
 
 \ /
  Last update: 2020-11-27 13:44    [W:0.082 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site