lkml.org 
[lkml]   [2020]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6] usb-serial:cp210x: add support to software flow control
[ Again, please do not top-post. Quoting Greg:

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top
]

On Mon, Nov 23, 2020 at 01:11:24AM +0000, Wang, Sheng Long wrote:
> Hi, Johan
>
> Do I add my software flow control patch directly to the branch you
> gave me now ?
> https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/log/?h=cp210x-termios

Yes, please rebase your work on top of that branch. I'll merge it to my
usb-next branch before applying your patch.

> Then, I also need the cp210x_ get_ terminus() add ixoff / iXon handling?

No, if you rebase your work on top of the above branch, you won't have
to deal with cp210x_get_termios() which has now been removed.

Just add support for software flow control to the new
cp210x_set_flow_control() function (and cp210x_termios_change()).

I think you can even drop get_special_chars() and just leave the rest
set as NUL, which appears to be the default.

Johan

\
 
 \ /
  Last update: 2020-11-27 11:25    [W:0.052 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site