Messages in this thread |  | | Date | Fri, 27 Nov 2020 09:57:03 +0000 | From | Marc Zyngier <> | Subject | Re: [PATCH v2 1/3] genirq/affinity: Add irq_update_affinity_desc() |
| |
On 2020-11-26 16:52, John Garry wrote: > Hi Marc, > >>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/log/?h=irq/hacks >> >> >> ok, I'll have a look > > I tried that and it doesn't look to work. > > I find that for the its_msi_prepare() call, its_dev->shared does not > get set, as MSI_ALLOC_FLAGS_SHARED_DEVICE is not set in info->flags. > > If I understand the code correctly, MSI_ALLOC_FLAGS_SHARED_DEVICE is > supposed to be set in info->flags in platform_msi_set_desc(), but this > is called per-msi after its_msi_prepare(), so we don't the flags set > at the right time. That's how it looks to me...
Meh. I was trying multiple things, and of course commited the worse possible approach.
I've updated the branch, having verified that we do get the flag in the ITS now.
Thanks,
M. -- Jazz is not dead. It just smells funny...
|  |