Messages in this thread |  | | From | Geert Uytterhoeven <> | Date | Fri, 27 Nov 2020 10:34:07 +0100 | Subject | Re: [PATCH v2 1/5] memory: renesas-rpc-if: Return correct value to the caller of rpcif_manual_xfer() |
| |
On Thu, Nov 26, 2020 at 8:12 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > In the error path of rpcif_manual_xfer() the value of ret is overwritten > by value returned by reset_control_reset() function and thus returning > incorrect value to the caller. > > This patch makes sure the correct value is returned to the caller of > rpcif_manual_xfer() by dropping the overwrite of ret in error path. > Also now we ignore the value returned by reset_control_reset() in the > error path and instead print a error message when it fails. > > Fixes: ca7d8b980b67f ("memory: add Renesas RPC-IF driver") > Reported-by: Pavel Machek <pavel@denx.de> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Cc: stable@vger.kernel.org > Reviewed-by: Sergei Shtylyov <sergei.shtylyov@gmail.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
|  |