Messages in this thread | | | From | KP Singh <> | Date | Thu, 26 Nov 2020 23:58:03 +0100 | Subject | Re: [PATCH bpf-next v3 1/6] net: Remove the err argument from sock_from_file |
| |
On Thu, Nov 26, 2020 at 5:45 PM Florent Revest <revest@chromium.org> wrote: > > Currently, the sock_from_file prototype takes an "err" pointer that is > either not set or set to -ENOTSOCK IFF the returned socket is NULL. This > makes the error redundant and it is ignored by a few callers. > > This patch simplifies the API by letting callers deduce the error based > on whether the returned socket is NULL or not. > > Suggested-by: Al Viro <viro@zeniv.linux.org.uk> > Signed-off-by: Florent Revest <revest@google.com>
Reviewed-by: KP Singh <kpsingh@google.com>
| |