lkml.org 
[lkml]   [2020]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v3 2/5] ACPI: Make acpi_dev_irqresource_disabled() public
On Thu, Nov 26, 2020 at 9:49 AM John Garry <john.garry@huawei.com> wrote:
>
> On 25/11/2020 17:43, Rafael J. Wysocki wrote:
> > On Wed, Nov 25, 2020 at 6:25 PM John Garry<john.garry@huawei.com> wrote:
> >> To allow the platform device to "put" an irq, make the function to reset
> >> an ACPI companion device irq resource public.
> >>
> >> Signed-off-by: John Garry<john.garry@huawei.com>
> > I'd rather move it to kernel/resource.c as it is not ACPI-specific and
> > its only connection to ACPI is that it is used in the ACPI resources
> > management code.
> >
>
> Hi Rafael,
>
> That's ok, but we could also just put in include/linux/ioport.h as a
> static inline as it’s so small. Not so important, I guess.
>
> And I'm not sure how this part could be merged, so maybe I can do as 2x
> patches now - 1. add resource.c function 2. remove ACPI duplicate. - so
> we have the option to merge ACPI part later if it makes things easier.

That would work too.

My point really was that exporting that function from ACPI was rather confusing.

\
 
 \ /
  Last update: 2020-11-26 15:27    [W:0.060 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site