lkml.org 
[lkml]   [2020]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/8] net: ethernet: smsc: smc91x: Demote non-conformant kernel function header
    Date
    Fixes the following W=1 kernel build warning(s):

    drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'dev' not described in 'try_toggle_control_gpio'
    drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'desc' not described in 'try_toggle_control_gpio'
    drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'name' not described in 'try_toggle_control_gpio'
    drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'index' not described in 'try_toggle_control_gpio'
    drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'value' not described in 'try_toggle_control_gpio'
    drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'nsdelay' not described in 'try_toggle_control_gpio'

    Cc: Nicolas Pitre <nico@fluxnic.net>
    Cc: "David S. Miller" <davem@davemloft.net>
    Cc: Jakub Kicinski <kuba@kernel.org>
    Cc: Erik Stahlman <erik@vt.edu>
    Cc: Peter Cammaert <pc@denkart.be>
    Cc: Daris A Nevil <dnevil@snmc.com>
    Cc: Russell King <rmk@arm.linux.org.uk>
    Cc: netdev@vger.kernel.org
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    ---
    drivers/net/ethernet/smsc/smc91x.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c
    index 56c36798cb111..3b90dc065ff2d 100644
    --- a/drivers/net/ethernet/smsc/smc91x.c
    +++ b/drivers/net/ethernet/smsc/smc91x.c
    @@ -2191,7 +2191,7 @@ static const struct of_device_id smc91x_match[] = {
    MODULE_DEVICE_TABLE(of, smc91x_match);

    #if defined(CONFIG_GPIOLIB)
    -/**
    +/*
    * of_try_set_control_gpio - configure a gpio if it exists
    * @dev: net device
    * @desc: where to store the GPIO descriptor, if it exists
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-11-26 14:40    [W:4.133 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site