Messages in this thread | | | From | "Liao, Bard" <> | Subject | RE: [PATCH] regmap: sdw: add required header files | Date | Thu, 26 Nov 2020 10:37:18 +0000 |
| |
> -----Original Message----- > From: Greg KH <gregkh@linuxfoundation.org> > Sent: Thursday, November 26, 2020 1:35 PM > To: Bard Liao <yung-chuan.liao@linux.intel.com> > Cc: alsa-devel@alsa-project.org; vkoul@kernel.org; vinod.koul@linaro.org; > linux-kernel@vger.kernel.org; tiwai@suse.de; broonie@kernel.org; > jank@cadence.com; srinivas.kandagatla@linaro.org; > rander.wang@linux.intel.com; ranjani.sridharan@linux.intel.com; > hui.wang@canonical.com; pierre-louis.bossart@linux.intel.com; Kale, Sanyog > R <sanyog.r.kale@intel.com>; Liao, Bard <bard.liao@intel.com> > Subject: Re: [PATCH] regmap: sdw: add required header files > > On Wed, Nov 25, 2020 at 09:01:28PM +0800, Bard Liao wrote: > > From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > > > > Explicitly add header files used by regmap SoundWire support. > > What is failing to build without this?
I didn't see build errors. But, Documentation/process/submit-checklist.rst says. 1) If you use a facility then #include the file that defines/declares that facility. Don't depend on other header files pulling in ones that you use.
> > thanks, > > greg k-h
| |