Messages in this thread | | | Date | Thu, 26 Nov 2020 12:30:23 +0100 | From | Thierry Reding <> | Subject | Re: [PATCH] PCI: tegra: Read "dbi" base address to program in application logic |
| |
On Thu, Nov 26, 2020 at 12:55:54AM +0530, Vidya Sagar wrote: > PCIe controller in Tegra194 requires the "dbi" region base address to be > programmed in one of the application logic registers to enable CPU access > to the "dbi" region. But, commit a0fd361db8e5 ("PCI: dwc: Move "dbi", > "dbi2", and "addr_space" resource setup into common code") moved the code > that reads the whereabouts of "dbi" region to the common code causing the > existing code in pcie-tegra194.c file to program NULL in the application > logic registers. This is causing null pointer dereference when the "dbi" > registers are accessed. This issue is fixed by explicitly reading the > "dbi" base address from DT node. > > Fixes: a0fd361db8e5 ("PCI: dwc: Move "dbi", "dbi2", and "addr_space" resource setup into common code") > Signed-off-by: Vidya Sagar <vidyas@nvidia.com> > --- > drivers/pci/controller/dwc/pcie-tegra194.c | 7 +++++++ > 1 file changed, 7 insertions(+)
Tested-by: Thierry Reding <treding@nvidia.com> Acked-by: Thierry Reding <treding@nvidia.com> [unhandled content-type:application/pgp-signature] | |