Messages in this thread | | | Date | Wed, 25 Nov 2020 14:17:56 +0000 | From | Will Deacon <> | Subject | Re: [PATCH v9 00/16] perf arm-spe: Refactor decoding & dumping flow |
| |
On Thu, Nov 19, 2020 at 11:24:25PM +0800, Leo Yan wrote: > This is patch set v9 for refactoring Arm SPE trace decoding and dumping. > > According to comments and suggestions from patch set v8, it squashs the > two patches into single one: "perf arm-spe: Refactor printing string to > buffer" and "perf arm-spe: Consolidate arm_spe_pkt_desc()'s return > value". > > In the patch 01/16, it renames the function arm_spe_pkt_snprintf() to > arm_spe_pkt_out_string(), since the function is not the same semantics > with snprintf(), the renaming can avoid confusion. > > This patch set is cleanly applied on the top of perf/core branch > with commit 29396cd573da ("perf expr: Force encapsulation on > expr_id_data"). > > This patch set has been tested on Hisilicon D06 platform with commands > "perf report -D" and "perf script", compared the decoding results > between with this patch set and without this patch set, "diff" tool > shows the result as expected. > > I also manually built the patches for arm/arm64/x86_64 and verfied > every single patch can build successfully.
I'm unable to test this, so I'm please that you can! Anyway, it all looks fine from a quick look:
Acked-by: Will Deacon <will@kernel.org>
so I think Arnaldo can pick this up when he's ready.
Cheers,
Will
| |