lkml.org 
[lkml]   [2020]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] HID: intel-ish-hid: Remove unnecessary assignment to variable rv
On Tue, 10 Nov 2020, Jing Xiangfeng wrote:

> This assignment to rv is unused in an error path. So remove it.
>
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
> ---
> drivers/hid/intel-ish-hid/ishtp-hid.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/hid/intel-ish-hid/ishtp-hid.c b/drivers/hid/intel-ish-hid/ishtp-hid.c
> index b8aae69ad15d..393bed0abee9 100644
> --- a/drivers/hid/intel-ish-hid/ishtp-hid.c
> +++ b/drivers/hid/intel-ish-hid/ishtp-hid.c
> @@ -211,10 +211,8 @@ int ishtp_hid_probe(unsigned int cur_hid_dev,
> struct ishtp_hid_data *hid_data;
>
> hid = hid_allocate_device();
> - if (IS_ERR(hid)) {
> - rv = PTR_ERR(hid);
> - return -ENOMEM;
> - }
> + if (IS_ERR(hid))
> + return PTR_ERR(hid);
>

Applied, thank you.

--
Jiri Kosina
SUSE Labs

\
 
 \ /
  Last update: 2020-11-25 13:59    [W:0.034 / U:1.676 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site