Messages in this thread | | | Date | Wed, 25 Nov 2020 13:05:07 +0100 | From | Jan Kara <> | Subject | Re: [PATCH] trace: fix potenial dangerous pointer |
| |
On Tue 24-11-20 12:09:02, Tejun Heo wrote: > On Tue, Nov 24, 2020 at 12:05:23PM -0500, Steven Rostedt wrote: > > On Wed, 25 Nov 2020 00:52:05 +0800 > > Hui Su <sh_def@163.com> wrote: > > > > > The bdi_dev_name() returns a char [64], and > > > the __entry->name is a char [32]. > > > > > > It maybe dangerous to TP_printk("%s", __entry->name) > > > after the strncpy(). > > > > Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org> > > > > This should go through the tree that has the code that uses these > > tracepoints. > > Acked-by: Tejun Heo <tj@kernel.org> > > Andrew, can you please route this one?
I'll queue it to my tree and push it to Linus on Friday since I sometimes handle writeback stuff myself anyway...
Honza -- Jan Kara <jack@suse.com> SUSE Labs, CR
| |