lkml.org 
[lkml]   [2020]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 2/2] mm: Move free_unref_page to mm/internal.h
    From
    Date
    On 25.11.20 04:46, Matthew Wilcox (Oracle) wrote:
    > Code outside mm/ should not be calling free_unref_page(). Also
    > move free_unref_page_list().
    >
    > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
    > ---
    > include/linux/gfp.h | 2 --
    > mm/internal.h | 3 +++
    > 2 files changed, 3 insertions(+), 2 deletions(-)
    >
    > diff --git a/include/linux/gfp.h b/include/linux/gfp.h
    > index c603237e006c..6e479e9c48ce 100644
    > --- a/include/linux/gfp.h
    > +++ b/include/linux/gfp.h
    > @@ -580,8 +580,6 @@ void * __meminit alloc_pages_exact_nid(int nid, size_t size, gfp_t gfp_mask);
    >
    > extern void __free_pages(struct page *page, unsigned int order);
    > extern void free_pages(unsigned long addr, unsigned int order);
    > -extern void free_unref_page(struct page *page);
    > -extern void free_unref_page_list(struct list_head *list);
    >
    > struct page_frag_cache;
    > extern void __page_frag_cache_drain(struct page *page, unsigned int count);
    > diff --git a/mm/internal.h b/mm/internal.h
    > index 75ae680d0a2c..5864815947fe 100644
    > --- a/mm/internal.h
    > +++ b/mm/internal.h
    > @@ -201,6 +201,9 @@ extern void post_alloc_hook(struct page *page, unsigned int order,
    > gfp_t gfp_flags);
    > extern int user_min_free_kbytes;
    >
    > +extern void free_unref_page(struct page *page);
    > +extern void free_unref_page_list(struct list_head *list);
    > +
    > extern void zone_pcp_update(struct zone *zone);
    > extern void zone_pcp_reset(struct zone *zone);
    > extern void zone_pcp_disable(struct zone *zone);
    >

    Reviewed-by: David Hildenbrand <david@redhat.com>

    --
    Thanks,

    David / dhildenb

    \
     
     \ /
      Last update: 2020-11-25 09:44    [W:2.356 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site