lkml.org 
[lkml]   [2020]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 22/25] perf buildid-cache: Add support to add build ids from perf data
On Thu, Nov 26, 2020 at 1:36 AM Jiri Olsa <jolsa@redhat.com> wrote:
>
> On Wed, Nov 25, 2020 at 10:00:10PM +0900, Namhyung Kim wrote:
> > On Tue, Nov 24, 2020 at 8:06 AM Jiri Olsa <jolsa@kernel.org> wrote:
> > >
> > > Adding support to specify perf data file as -a option file
> > > argument,
> > >
> > > If the file is detected to be perf data file, it is processed
> > > and all dso objects with sample hit are stored to the build
> > > id cache.
> > >
> > > $ DEBUGINFOD_URLS=http://192.168.122.174:8002 perf buildid-cache -a perf.data
> > > OK 5dcec522abf136fcfd3128f47e131f2365834dd7 /home/jolsa/.debug/.build-id/5d/cec522abf136fcfd3128f47e131f2365834dd7/elf
> > > OK 5784f813b727a50cfd3363234aef9fcbab685cc4 /lib/modules/5.10.0-rc2speed+/kernel/fs/xfs/xfs.ko
> > >
> > > By default we store only dso with hits, but it's possible to
> > > specify 'all' to store all dso objects, like:
> > > -a perf.data,all
> >
> > I think we can add -A/--add-all like we have -p and -P.
>
> hm, the thing is that 'all' is specific for perf data file: '-a perf.data'
> hence -A 'file' would make no sense, only for '-A perf.data', so the current
> 'all' parameter seems less confusing to me

Yeah, I also thought about the '-A perf.data' form.
But I won't insist on it strongly, it's up to you. :)

Thanks,
Namhyung

\
 
 \ /
  Last update: 2020-11-26 05:53    [W:0.062 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site