Messages in this thread |  | | Date | Tue, 24 Nov 2020 17:07:32 +0000 | From | Mark Brown <> | Subject | Re: [PATCH v3 5/8] regulator: mt6359: Add support for MT6359 regulator |
| |
On Mon, Nov 23, 2020 at 11:48:07AM +0800, Hsin-Hsiung Wang wrote:
> +static int mt6359_get_linear_voltage_sel(struct regulator_dev *rdev) > +{ > + struct mt6359_regulator_info *info = rdev_get_drvdata(rdev); > + int ret, regval; > + > + ret = regmap_read(rdev->regmap, info->da_vsel_reg, ®val); > + if (ret != 0) { > + dev_err(&rdev->dev, > + "Failed to get mt6359 Buck %s vsel reg: %d\n", > + info->desc.name, ret); > + return ret; > + } > + > + ret = (regval >> info->da_vsel_shift) & info->da_vsel_mask; > + > + return ret; > +}
This looks like it could just be regmap_get_voltage_sel_regmap()? Otherwise the driver looks good. [unhandled content-type:application/pgp-signature] |  |