Messages in this thread |  | | Subject | Re: [PATCH v2 1/4] sbitmap: optimise sbitmap_deferred_clear() | From | John Garry <> | Date | Tue, 24 Nov 2020 14:11:51 +0000 |
| |
On 22/11/2020 15:35, Pavel Begunkov wrote: > Because of spinlocks and atomics sbitmap_deferred_clear() have to reload > &sb->map[index] on each access even though the map address won't change. > Pass in sbitmap_word instead of {sb, index}, so it's cached in a > variable. It also improves code generation of > sbitmap_find_bit_in_index(). > > Signed-off-by: Pavel Begunkov<asml.silence@gmail.com>
Looks ok, even though a bit odd not be passing a struct sbitmap * now
Reviewed-by: John Garry <john.garry@huawei.com>
|  |