lkml.org 
[lkml]   [2020]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v3 1/6] regulator: core: validate selector against linear_min_sel
    From
    Date

    On 24/11/2020 11:14, Claudiu.Beznea@microchip.com wrote:

    ...

    > I would say that a solution would be to have a new helper to retrieve the
    > linear_min_sel (e.g. regulator_min_sel()) and use this for all the
    > consumers of regulator_list_voltage() and the other APIs that patch
    > "regulator: core: validate selector against linear_min_sel" has changed
    > (regulator_list_voltage_table(), regulator_set_voltage_time()). With this
    > change the loop in find_vdd_map_entry_exact() should be b/w
    > regulator_min_sel() and regulator_count_voltages().
    >
    > Maybe Mark has a better solution for this.


    By the way, I don't think that Tegra is alone here. I see some other
    drivers doing some similar things [0][1][2] and so I am wondering if
    this is going to be a problem for a few drivers.

    Jon

    [0]
    https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/mmc/core/regulator.c#n61
    [1]
    https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/cpufreq/s3c2416-cpufreq.c#n263
    [2]
    https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/leds/leds-regulator.c#n29

    --
    nvpublic

    \
     
     \ /
      Last update: 2020-11-24 14:44    [W:2.966 / U:0.444 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site