Messages in this thread | | | From | Luis Henriques <> | Subject | Re: [PATCH v2] ceph: add ceph.caps vxattr | Date | Tue, 24 Nov 2020 13:15:57 +0000 |
| |
Jeff Layton <jlayton@kernel.org> writes:
> On Mon, 2020-11-23 at 17:38 +0000, Luis Henriques wrote: >> Add a new vxattr that allows userspace to list the caps for a specific >> directory or file. >> >> Signed-off-by: Luis Henriques <lhenriques@suse.de> >> --- >> Hi! >> >> Here's a version that also shows the caps in hexadecimal format, as >> suggested by Jeff. IMO the parenthesis and the '0x' prefix help the >> readability, but they may make it a bit harder for scripts to parsing the >> output. I'm OK dropping those. >> >> Cheers, > > Looks good, merged into "testing".
Awesome, thanks!
> I did make a slight change to the format -- instead of putting the hex > value in parenthesis, I separated the two fields with a /, which I think > should make things easier for scripts to parse. > > You should be able to do something like this to get at the hex value for > testing: > > $ getfattr -n ceph.caps foo | cut -d / -f2 > > Let me know if you see issues with that and we can revisit the format.
Sure, I'm OK with that. Or even simply dropping any separator, having only a space/tab between the string and the hex value.
Another option I saw was to have two vxattrs: ceph.caps.string and ceph.caps.int. But that's probably overkill.
Cheers, -- Luis
| |