Messages in this thread | | | From | Ulf Hansson <> | Date | Tue, 24 Nov 2020 11:56:53 +0100 | Subject | Re: [PATCH 3/4] amba: Make the remove callback return void |
| |
On Tue, 24 Nov 2020 at 11:33, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > > Most amba drivers return 0 in their remove callback. Together with the > driver core ignoring the return value anyhow, it doesn't make sense to > return a value here. > > So add a warning to the only driver that could return an error code and > change the remove prototype to return void, which makes it explicit that > returning an error value doesn't work as expected. This simplifies changing > the core remove callback to return void, too. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
[...]
> diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c > index 6772f23e5c4b..de71058d131d 100644 > --- a/drivers/hwtracing/coresight/coresight-replicator.c > +++ b/drivers/hwtracing/coresight/coresight-replicator.c > @@ -390,7 +390,7 @@ static int dynamic_replicator_probe(struct amba_device *adev, > > static int __exit dynamic_replicator_remove(struct amba_device *adev)
Looks like you missed to convert this to void.
> { > - return replicator_remove(&adev->dev); > + replicator_remove(&adev->dev); > }
Other the above, feel free to add:
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
[...]
Kind regards Uffe
| |