Messages in this thread Patch in this message | | | From | Lukas Bulwahn <> | Subject | [PATCH] zlib: define get_unaligned16() only when used | Date | Tue, 24 Nov 2020 11:40:30 +0100 |
| |
Since commit acaab7335bd6 ("lib/zlib: remove outdated and incorrect pre-increment optimization"), get_unaligned16() is only used when !CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS.
Hence, make CC=clang W=1 warns:
lib/zlib_inflate/inffast.c:20:1: warning: unused function 'get_unaligned16' [-Wunused-function]
Define get_unaligned16() only when it is actually used.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> --- applies cleanly on current master and next-20201124
Jann, please ack. Andrew, please pick this minor non-urgent clean-up patch.
lib/zlib_inflate/inffast.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/zlib_inflate/inffast.c b/lib/zlib_inflate/inffast.c index ed1f3df27260..ca66d9008228 100644 --- a/lib/zlib_inflate/inffast.c +++ b/lib/zlib_inflate/inffast.c @@ -15,7 +15,8 @@ union uu { unsigned char b[2]; }; -/* Endian independed version */ +#ifndef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS +/* Endian independent version */ static inline unsigned short get_unaligned16(const unsigned short *p) { @@ -26,6 +27,7 @@ get_unaligned16(const unsigned short *p) mm.b[1] = b[1]; return mm.us; } +#endif /* Decode literal, length, and distance codes and write out the resulting -- 2.17.1
| |