Messages in this thread | | | From | Jianyong Wu <> | Subject | RE: [PATCH v15 6/9] arm64/kvm: Add hypercall service for kvm ptp. | Date | Tue, 24 Nov 2020 10:14:23 +0000 |
| |
Hi Marc,
> -----Original Message----- > From: Marc Zyngier <maz@kernel.org> > Sent: Tuesday, November 24, 2020 5:07 PM > To: Jianyong Wu <Jianyong.Wu@arm.com> > Cc: netdev@vger.kernel.org; yangbo.lu@nxp.com; john.stultz@linaro.org; > tglx@linutronix.de; pbonzini@redhat.com; sean.j.christopherson@intel.com; > richardcochran@gmail.com; Mark Rutland <Mark.Rutland@arm.com>; > will@kernel.org; Suzuki Poulose <Suzuki.Poulose@arm.com>; Andre > Przywara <Andre.Przywara@arm.com>; Steven Price > <Steven.Price@arm.com>; linux-kernel@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; kvmarm@lists.cs.columbia.edu; > kvm@vger.kernel.org; Steve Capper <Steve.Capper@arm.com>; Justin He > <Justin.He@arm.com>; nd <nd@arm.com> > Subject: Re: [PATCH v15 6/9] arm64/kvm: Add hypercall service for kvm ptp. > > On 2020-11-24 05:20, Jianyong Wu wrote: > > Hi Marc, > > [...] > > >> > +/* ptp_kvm counter type ID */ > >> > +#define ARM_PTP_VIRT_COUNTER 0 > >> > +#define ARM_PTP_PHY_COUNTER 1 > >> > +#define ARM_PTP_NONE_COUNTER 2 > >> > >> The architecture definitely doesn't have this last counter. > > > > Yeah, this is just represent no counter data needed from guest. > > Some annotation should be added here. > > I'd rather you remove it entirely, or explain why you really cannot do without > a fake counter.
OK, I will remove it.
Thanks Jianyong > > M. > -- > Jazz is not dead. It just smells funny...
| |