Messages in this thread | | | From | Clark Wang <> | Subject | RE: [EXT] [PATCH] spi: imx: enable runtime pm support | Date | Tue, 24 Nov 2020 08:57:28 +0000 |
| |
Hi Nikita,
Sorry for this issue caused by my patch. Yes, it because I did not add the !CONFIG_PM support when add the runtime pm patch. This may cause the clks cannot be enabled when do not enable CONFIG_PM. Sascha has fix this issue with the patch: 43b6bf406cd0 spi: imx: fix runtime pm support for !CONFIG_PM
You may try the latest upstream driver again.
I also fix a warning dump issue with CONFIG_PM enabled. It is under reviewed. So that, this driver can work well in both cases.
Thanks!
Best Regards, Clark Wang
> -----Original Message----- > From: Nikita Shubin <nikita.shubin@maquefel.me> > Sent: Friday, November 13, 2020 17:18 > To: Clark Wang <xiaoning.wang@nxp.com> > Cc: broonie@kernel.org; festevam@gmail.com; kernel@pengutronix.de; > linux-arm-kernel@lists.infradead.org; dl-linux-imx <linux-imx@nxp.com>; > linux-kernel@vger.kernel.org; linux-spi@vger.kernel.org; > s.hauer@pengutronix.de; shawnguo@kernel.org; Nikita Shubin > <nikita.shubin@maquefel.me> > Subject: [EXT] [PATCH] spi: imx: enable runtime pm support > > Caution: EXT Email > > Hello Clark, > > This patch breaks spi-imx on imx7d. > Toradex Colibri imx7d spi reports with: > > [ 4.258468] inv-mpu6000-spi spi2.0: I/O Error in PIO > [ 4.264269] inv-mpu6000-spi spi2.0: SPI transfer failed: -110 > [ 4.264305] spi_master spi2: failed to transfer one message from queue > > We are using spi-imx with dma. > > Reverting your patch fixes this issue. > > The baseline commit 951cbbc386ff01b50da4f46387e994e81d9ab431 (tag: > v5.9.8, stable/linux-5.9.y) > > Could you please give some comments on this issue ?
| |