lkml.org 
[lkml]   [2020]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 3/3] scsi: ufs: Print host regs in IRQ handler when AH8 error happens
On 2020-11-18 01:23, Asutosh Das (asd) wrote:
> On 11/16/2020 11:04 PM, Can Guo wrote:
>> When AH8 error happens, all the regs and states are dumped in err
>> handler.
>> Sometime we need to look into host regs right after AH8 error happens,
>> which is before leaving the IRQ handler.
>>
>> Signed-off-by: Can Guo <cang@codeaurora.org>
>> ---
>
> Reviewed-by: Asutosh Das <asutoshd@codeaurora.org>
>
>> drivers/scsi/ufs/ufshcd.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
>> index cd7394e..a7857f6 100644
>> --- a/drivers/scsi/ufs/ufshcd.c
>> +++ b/drivers/scsi/ufs/ufshcd.c
>> @@ -6057,7 +6057,8 @@ static irqreturn_t ufshcd_check_errors(struct
>> ufs_hba *hba)
>> hba->saved_uic_err |= hba->uic_error;
>> /* dump controller state before resetting */
>> - if ((hba->saved_err & (INT_FATAL_ERRORS)) ||
>> + if ((hba->saved_err &
>> + (INT_FATAL_ERRORS | UFSHCD_UIC_HIBERN8_MASK)) ||
>> (hba->saved_uic_err &&
>> (hba->saved_uic_err != UFSHCD_UIC_PA_GENERIC_ERROR))) {
>> dev_err(hba->dev, "%s: saved_err 0x%x saved_uic_err 0x%x\n",
>>

Reviewed-by: Hongwu Su<hongwus@codeaurora.org>

\
 
 \ /
  Last update: 2020-11-25 03:52    [W:0.058 / U:0.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site