Messages in this thread | | | Date | Tue, 24 Nov 2020 08:43:50 +0100 | From | Sascha Hauer <> | Subject | Re: [PATCH] bdi: Fix error return code in alloc_wbufs() |
| |
On Sun, Nov 15, 2020 at 04:23:43PM +0800, Wang ShaoBo wrote: > Fix to return PTR_ERR() error code from the error handling case instead > fo 0 in function alloc_wbufs(), as done elsewhere in this function. > > Fixes: 6a98bc4614de ("ubifs: Add authentication nodes to journal") > Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com> > --- > fs/ubifs/super.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-)
Prefix for this patch should be "ubifs:" rather than "bdi:". With this:
Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de>
Sascha
> > diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c > index cb3acfb7dd1f..dacbb999ae34 100644 > --- a/fs/ubifs/super.c > +++ b/fs/ubifs/super.c > @@ -838,8 +838,10 @@ static int alloc_wbufs(struct ubifs_info *c) > c->jheads[i].wbuf.jhead = i; > c->jheads[i].grouped = 1; > c->jheads[i].log_hash = ubifs_hash_get_desc(c); > - if (IS_ERR(c->jheads[i].log_hash)) > + if (IS_ERR(c->jheads[i].log_hash)) { > + err = PTR_ERR(c->jheads[i].log_hash); > goto out; > + } > } > > /* > -- > 2.25.1 > >
-- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
| |