Messages in this thread Patch in this message | | | Date | Tue, 24 Nov 2020 18:24:09 +0000 | Subject | [PATCH] modpost: Make static exports fatal | From | Quentin Perret <> |
| |
Using EXPORT_SYMBOL*() on static functions is fundamentally wrong. Modpost currently reports that as a warning, but clearly this is not a pattern we should allow, and all in-tree occurences should have been fixed by now. So, promote the warn() message to fatal() to make sure this never happens again.
Signed-off-by: Quentin Perret <qperret@google.com> --- scripts/mod/modpost.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index f882ce0d9327..70b0e825a139 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -2663,9 +2663,9 @@ int main(int argc, char **argv) for (s = symbolhash[n]; s; s = s->next) { if (s->is_static) - warn("\"%s\" [%s] is a static %s\n", - s->name, s->module->name, - export_str(s->export)); + fatal("\"%s\" [%s] is a static %s\n", + s->name, s->module->name, + export_str(s->export)); } } -- 2.29.2.454.gaff20da3a2-goog
| |