lkml.org 
[lkml]   [2020]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 082/158] can: tcan4x5x: replace depends on REGMAP_SPI with depends on SPI
    Date
    From: Enric Balletbo i Serra <enric.balletbo@collabora.com>

    [ Upstream commit 3fcce133f0d9a50d3a23f8e2bc950197b4e03900 ]

    regmap is a library function that gets selected by drivers that need it. No
    driver modules should depend on it. Instead depends on SPI and select
    REGMAP_SPI. Depending on REGMAP_SPI makes this driver only build if another
    driver already selected REGMAP_SPI, as the symbol can't be selected through the
    menu kernel configuration.

    Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
    Link: http://lore.kernel.org/r/20200413141013.506613-1-enric.balletbo@collabora.com
    Reviewed-by: Dan Murphy <dmurphy@ti.com>
    Fixes: 5443c226ba91 ("can: tcan4x5x: Add tcan4x5x driver to the kernel")
    Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/can/m_can/Kconfig | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/can/m_can/Kconfig b/drivers/net/can/m_can/Kconfig
    index 1ff0b7fe81d6a..c10932a7f1fe3 100644
    --- a/drivers/net/can/m_can/Kconfig
    +++ b/drivers/net/can/m_can/Kconfig
    @@ -16,7 +16,8 @@ config CAN_M_CAN_PLATFORM

    config CAN_M_CAN_TCAN4X5X
    depends on CAN_M_CAN
    - depends on REGMAP_SPI
    + depends on SPI
    + select REGMAP_SPI
    tristate "TCAN4X5X M_CAN device"
    ---help---
    Say Y here if you want support for Texas Instruments TCAN4x5x
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-11-23 14:41    [W:2.317 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site