lkml.org 
[lkml]   [2020]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 087/252] ARM: dts: sun9i: Enable both RGMII RX/TX delay on Ethernet PHY
    Date
    From: Chen-Yu Tsai <wens@csie.org>

    [ Upstream commit b1064037e8ecf09d587b7b4966eebe0c362908e5 ]

    The Ethernet PHY on the Cubieboard 4 and A80 Optimus have the RX
    and TX delays enabled on the PHY, using pull-ups on the RXDLY and
    TXDLY pins.

    Fix the phy-mode description to correct reflect this so that the
    implementation doesn't reconfigure the delays incorrectly. This
    happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e
    rx/tx delay config").

    Fixes: 98048143b7f8 ("ARM: dts: sun9i: cubieboard4: Enable GMAC")
    Fixes: bc9bd03a44f9 ("ARM: dts: sun9i: a80-optimus: Enable GMAC")
    Signed-off-by: Chen-Yu Tsai <wens@csie.org>
    Signed-off-by: Maxime Ripard <maxime@cerno.tech>
    Acked-by: Jernej Skrabec <jernej.skrabec@siol.net>
    Link: https://lore.kernel.org/r/20201024162515.30032-7-wens@kernel.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/arm/boot/dts/sun9i-a80-cubieboard4.dts | 2 +-
    arch/arm/boot/dts/sun9i-a80-optimus.dts | 2 +-
    2 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts b/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts
    index d3b337b043a15..484b93df20cb6 100644
    --- a/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts
    +++ b/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts
    @@ -129,7 +129,7 @@
    pinctrl-names = "default";
    pinctrl-0 = <&gmac_rgmii_pins>;
    phy-handle = <&phy1>;
    - phy-mode = "rgmii";
    + phy-mode = "rgmii-id";
    phy-supply = <&reg_cldo1>;
    status = "okay";
    };
    diff --git a/arch/arm/boot/dts/sun9i-a80-optimus.dts b/arch/arm/boot/dts/sun9i-a80-optimus.dts
    index bbc6335e56314..5c3580d712e40 100644
    --- a/arch/arm/boot/dts/sun9i-a80-optimus.dts
    +++ b/arch/arm/boot/dts/sun9i-a80-optimus.dts
    @@ -124,7 +124,7 @@
    pinctrl-names = "default";
    pinctrl-0 = <&gmac_rgmii_pins>;
    phy-handle = <&phy1>;
    - phy-mode = "rgmii";
    + phy-mode = "rgmii-id";
    phy-supply = <&reg_cldo1>;
    status = "okay";
    };
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-11-23 14:15    [W:3.194 / U:2.952 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site