lkml.org 
[lkml]   [2020]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 051/158] Revert "arm: sun8i: orangepi-pc-plus: Set EMAC activity LEDs to active high"
    Date
    From: Chen-Yu Tsai <wens@csie.org>

    [ Upstream commit 8d80e2f00a42ef10b54e1b2d9e97314f8fd046c0 ]

    This reverts commit 75ee680cbd2e4d0156b94f9fec50076361ab12f2.

    Turns out the activity and link LEDs on the RJ45 port are active low,
    just like on the Orange Pi PC.

    Revert the commit that says otherwise.

    Fixes: 75ee680cbd2e ("arm: sun8i: orangepi-pc-plus: Set EMAC activity LEDs to active high")
    Fixes: 4904337fe34f ("ARM: dts: sunxi: Restore EMAC changes (boards)")
    Signed-off-by: Chen-Yu Tsai <wens@csie.org>
    Signed-off-by: Maxime Ripard <maxime@cerno.tech>
    Tested-by: Jernej Skrabec <jernej.skrabec@siol.net>
    Acked-by: Jernej Skrabec <jernej.skrabec@siol.net>
    Link: https://lore.kernel.org/r/20201024162515.30032-1-wens@kernel.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/arm/boot/dts/sun8i-h3-orangepi-pc-plus.dts | 5 -----
    1 file changed, 5 deletions(-)

    diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-pc-plus.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-pc-plus.dts
    index 71fb732089397..babf4cf1b2f68 100644
    --- a/arch/arm/boot/dts/sun8i-h3-orangepi-pc-plus.dts
    +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-pc-plus.dts
    @@ -53,11 +53,6 @@
    };
    };

    -&emac {
    - /* LEDs changed to active high on the plus */
    - /delete-property/ allwinner,leds-active-low;
    -};
    -
    &mmc1 {
    vmmc-supply = <&reg_vcc3v3>;
    bus-width = <4>;
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-11-23 14:09    [W:4.130 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site