lkml.org 
[lkml]   [2020]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 068/158] Input: resistive-adc-touch - fix kconfig dependency on IIO_BUFFER
    Date
    From: Necip Fazil Yildiran <fazilyildiran@gmail.com>

    [ Upstream commit 676650d007e06fddcf3fe38238251d71bd179641 ]

    When TOUCHSCREEN_ADC is enabled and IIO_BUFFER is disabled, it results
    in the following Kbuild warning:

    WARNING: unmet direct dependencies detected for IIO_BUFFER_CB
    Depends on [n]: IIO [=y] && IIO_BUFFER [=n]
    Selected by [y]:
    - TOUCHSCREEN_ADC [=y] && !UML && INPUT [=y] && INPUT_TOUCHSCREEN [=y] && IIO [=y]

    The reason is that TOUCHSCREEN_ADC selects IIO_BUFFER_CB without depending
    on or selecting IIO_BUFFER while IIO_BUFFER_CB depends on IIO_BUFFER. This
    can also fail building the kernel.

    Honor the kconfig dependency to remove unmet direct dependency warnings
    and avoid any potential build failures.

    Fixes: aa132ffb6b0a ("input: touchscreen: resistive-adc-touch: add generic resistive ADC touchscreen")
    Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
    Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    Link: https://lore.kernel.org/r/20201102221504.541279-1-fazilyildiran@gmail.com
    Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/input/touchscreen/Kconfig | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
    index 46ad9090493bb..1e812a193ce7a 100644
    --- a/drivers/input/touchscreen/Kconfig
    +++ b/drivers/input/touchscreen/Kconfig
    @@ -96,6 +96,7 @@ config TOUCHSCREEN_AD7879_SPI
    config TOUCHSCREEN_ADC
    tristate "Generic ADC based resistive touchscreen"
    depends on IIO
    + select IIO_BUFFER
    select IIO_BUFFER_CB
    help
    Say Y here if you want to use the generic ADC
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-11-23 14:09    [W:4.086 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site