lkml.org 
[lkml]   [2020]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 045/158] arm64: dts: allwinner: beelink-gs1: Enable both RGMII RX/TX delay
    Date
    From: Clément Péron <peron.clem@gmail.com>

    [ Upstream commit 97a38c1c213b162aa577299de698f39c18ba696b ]

    Before the commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx
    delay config"), the software overwrite for RX/TX delays of the RTL8211e
    were not working properly and the Beelink GS1 had both RX/TX delay of RGMII
    interface set using pull-up on the TXDLY and RXDLY pins.

    Now that these delays are working properly they overwrite the HW
    config and set this to 'rgmii' meaning no delay on both RX/TX.
    This makes the ethernet of this board not working anymore.

    Set the phy-mode to 'rgmii-id' meaning RGMII with RX/TX delays
    in the device-tree to keep the correct configuration.

    Fixes: 089bee8dd119 ("arm64: dts: allwinner: h6: Introduce Beelink GS1 board")
    Signed-off-by: Clément Péron <peron.clem@gmail.com>
    Signed-off-by: Maxime Ripard <maxime@cerno.tech>
    Acked-by: Chen-Yu Tsai <wens@csie.org>
    Link: https://lore.kernel.org/r/20201018172409.1754775-1-peron.clem@gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
    index 1d05d570142fa..0a04730960fcb 100644
    --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
    +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
    @@ -83,7 +83,7 @@
    &emac {
    pinctrl-names = "default";
    pinctrl-0 = <&ext_rgmii_pins>;
    - phy-mode = "rgmii";
    + phy-mode = "rgmii-id";
    phy-handle = <&ext_rgmii_phy>;
    phy-supply = <&reg_aldo2>;
    status = "okay";
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-11-23 14:09    [W:2.100 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site