lkml.org 
[lkml]   [2020]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 016/252] net: ethernet: mtk-star-emac: fix error return code in mtk_star_enable()
    Date
    From: Zhang Changzhong <zhangchangzhong@huawei.com>

    [ Upstream commit baee1991fad928d6c8dd5be3197ecb413c420c97 ]

    Fix to return a negative error code from the error handling
    case instead of 0, as done elsewhere in this function.

    Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
    Acked-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
    Link: https://lore.kernel.org/r/1605180879-2573-1-git-send-email-zhangchangzhong@huawei.com
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/mediatek/mtk_star_emac.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/net/ethernet/mediatek/mtk_star_emac.c
    +++ b/drivers/net/ethernet/mediatek/mtk_star_emac.c
    @@ -966,6 +966,7 @@ static int mtk_star_enable(struct net_de
    mtk_star_adjust_link, 0, priv->phy_intf);
    if (!priv->phydev) {
    netdev_err(ndev, "failed to connect to PHY\n");
    + ret = -ENODEV;
    goto err_free_irq;
    }


    \
     
     \ /
      Last update: 2020-11-23 14:09    [W:4.033 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site