lkml.org 
[lkml]   [2020]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 24/60] Input: adxl34x - clean up a data type in adxl34x_probe()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 33b6c39e747c552fa770eecebd1776f1f4a222b1 ]

    The "revid" is used to store negative error codes so it should be an int
    type.

    Fixes: e27c729219ad ("Input: add driver for ADXL345/346 Digital Accelerometers")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Acked-by: Michael Hennerich <michael.hennerich@analog.com>
    Link: https://lore.kernel.org/r/20201026072824.GA1620546@mwanda
    Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/input/misc/adxl34x.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/input/misc/adxl34x.c b/drivers/input/misc/adxl34x.c
    index 2b2d02f408bbb..2e189646d8fe2 100644
    --- a/drivers/input/misc/adxl34x.c
    +++ b/drivers/input/misc/adxl34x.c
    @@ -696,7 +696,7 @@ struct adxl34x *adxl34x_probe(struct device *dev, int irq,
    struct input_dev *input_dev;
    const struct adxl34x_platform_data *pdata;
    int err, range, i;
    - unsigned char revid;
    + int revid;

    if (!irq) {
    dev_err(dev, "no IRQ?\n");
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-11-23 13:33    [W:2.656 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site