lkml.org 
[lkml]   [2020]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 000/141] Fix fall-through warnings for Clang
From
Date
On Mon, 2020-11-23 at 18:05 -0800, Nick Desaulniers wrote:
> (minus all of these lists, except LKML, CBL, and ACPI)
>
> On Mon, Nov 23, 2020 at 5:46 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> > On Mon, 23 Nov 2020 17:32:51 -0800 Nick Desaulniers wrote:
> > > On Sun, Nov 22, 2020 at 8:17 AM Kees Cook <keescook@chromium.org> wrote:
> > > > On Fri, Nov 20, 2020 at 11:51:42AM -0800, Jakub Kicinski wrote:
> > > > > If none of the 140 patches here fix a real bug, and there is no
> > change
> > > > > to machine code then it sounds to me like a W=2 kind of a warning.
> > > >
> > > > FWIW, this series has found at least one bug so far:
> > > >
> > https://lore.kernel.org/lkml/CAFCwf11izHF=g1mGry1fE5kvFFFrxzhPSM6qKAO8gxSp=Kr_CQ@mail.gmail.com/
> >
> > >
> > > So looks like the bulk of these are:
> > > switch (x) {
> > >   case 0:
> > >     ++x;
> > >   default:
> > >     break;
> > > }
> > >
> > > I have a patch that fixes those up for clang:
> > > https://reviews.llvm.org/D91895

Pity. It's a good warning. gcc not warning is a mistake in my view.


\
 
 \ /
  Last update: 2020-11-24 03:30    [W:0.308 / U:0.680 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site