Messages in this thread | | | Date | Mon, 23 Nov 2020 23:26:59 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH 22/24] perf buildid-cache: Add --debuginfod option |
| |
On Thu, Nov 19, 2020 at 12:23:53PM -0800, Ian Rogers wrote: > On Mon, Nov 9, 2020 at 1:55 PM Jiri Olsa <jolsa@kernel.org> wrote: > > > Adding --debuginfod option to specify debuginfod url and > > support to do that through config file as well. > > > > Use following in ~/.perfconfig file: > > > > [buildid-cache] > > debuginfod=http://192.168.122.174:8002 > > > > Signed-off-by: Jiri Olsa <jolsa@kernel.org> > > --- > > .../perf/Documentation/perf-buildid-cache.txt | 4 +++ > > tools/perf/builtin-buildid-cache.c | 28 +++++++++++++++++-- > > 2 files changed, 29 insertions(+), 3 deletions(-) > > > > diff --git a/tools/perf/Documentation/perf-buildid-cache.txt > > b/tools/perf/Documentation/perf-buildid-cache.txt > > index b77da5138bca..0152d8b5cfbe 100644 > > --- a/tools/perf/Documentation/perf-buildid-cache.txt > > +++ b/tools/perf/Documentation/perf-buildid-cache.txt > > @@ -84,6 +84,10 @@ OPTIONS > > used when creating a uprobe for a process that resides in a > > different mount namespace from the perf(1) utility. > > > > +--debuginfod=URL:: > > + Specify debuginfod URL to be used when retrieving perf.data > > binaries, > > + it follows the same syntax as the DEBUGINFOD_URLS variable. > > + > > > > Acked-by: Ian Rogers <irogers@google.com> > > Nit: the environment variable name hints at this being a list, perhaps > change URL:: above to URLs:: to keep this clear.
true, will change that
thanks, jirka
| |