lkml.org 
[lkml]   [2020]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] scsi: hisi_sas: Move debugfs code to v3 hw driver
Hi John,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on scsi/for-next linus/master v5.10-rc5 next-20201123]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/John-Garry/hisi_sas-A-small-bunch-of-misc-patches/20201124-014754
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/ede79ead19f599aecdc68447f3bfd6418df29561
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review John-Garry/hisi_sas-A-small-bunch-of-misc-patches/20201124-014754
git checkout ede79ead19f599aecdc68447f3bfd6418df29561
# save the attached .config to linux build tree
make W=1 ARCH=x86_64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:4371:6: warning: no previous prototype for 'debugfs_init_v3_hw' [-Wmissing-prototypes]
4371 | void debugfs_init_v3_hw(struct hisi_hba *hisi_hba)
| ^~~~~~~~~~~~~~~~~~

vim +/debugfs_init_v3_hw +4371 drivers/scsi/hisi_sas/hisi_sas_v3_hw.c

4370
> 4371 void debugfs_init_v3_hw(struct hisi_hba *hisi_hba)
4372 {
4373 struct device *dev = hisi_hba->dev;
4374 int i;
4375
4376 hisi_hba->debugfs_dir = debugfs_create_dir(dev_name(dev),
4377 hisi_sas_debugfs_dir);
4378 debugfs_create_file("trigger_dump", 0200,
4379 hisi_hba->debugfs_dir,
4380 hisi_hba,
4381 &debugfs_trigger_dump_v3_hw_fops);
4382
4383 /* create bist structures */
4384 debugfs_bist_init_v3_hw(hisi_hba);
4385
4386 hisi_hba->debugfs_dump_dentry =
4387 debugfs_create_dir("dump", hisi_hba->debugfs_dir);
4388
4389 debugfs_phy_down_cnt_init_v3_hw(hisi_hba);
4390
4391 for (i = 0; i < hisi_sas_debugfs_dump_count; i++) {
4392 if (debugfs_alloc_v3_hw(hisi_hba, i)) {
4393 debugfs_remove_recursive(hisi_hba->debugfs_dir);
4394 dev_dbg(dev, "failed to init debugfs!\n");
4395 break;
4396 }
4397 }
4398 }
4399

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2020-11-23 22:31    [W:0.047 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site