Messages in this thread | | | Date | Mon, 23 Nov 2020 16:28:09 -0400 | From | Jason Gunthorpe <> | Subject | Re: [PATCH v2] IB/mthca: fix return value of error branch in mthca_init_cq() |
| |
On Fri, Nov 20, 2020 at 09:57:02AM +0800, Xiongfeng Wang wrote: > We return 'err' in the error branch, but this variable may be set as > zero by the above code. Fix it by setting 'err' as a negative value > before we goto the error label. > > Fixes: 74c2174e7be5 ("IB uverbs: add mthca user CQ support") > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com> > --- > drivers/infiniband/hw/mthca/mthca_cq.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-)
Applied to for-rc, thanks
Jason
| |