lkml.org 
[lkml]   [2020]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH 2/4] x86/mce: move the mce_panic() call and kill_it assignments at the right places
    Date
    > -----Original Message-----
    > From: Borislav Petkov <bp@alien8.de>
    > Sent: Monday, November 23, 2020 6:19 PM
    > To: Paoloni, Gabriele <gabriele.paoloni@intel.com>
    > Cc: Luck, Tony <tony.luck@intel.com>; tglx@linutronix.de;
    > mingo@redhat.com; x86@kernel.org; hpa@zytor.com; linux-
    > edac@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
    > safety@lists.elisa.tech
    > Subject: Re: [PATCH 2/4] x86/mce: move the mce_panic() call and kill_it
    > assignments at the right places
    >
    > On Mon, Nov 23, 2020 at 05:06:31PM +0000, Paoloni, Gabriele wrote:
    > > From my understanding no_way_out and kill_it are different in principles:
    > > no_way_out is telling that an error occurred 'somewhere' in some CPU
    > bank
    > > that requires the system to panic (e.g. PCC=1); kill_it is saying that the
    > execution
    > > cannot be restarted where it left for the local CPU and hence we need to
    > find
    > > an alternative solution as part of the recovery action. In practice it seems to
    > > me that kill_it is used to replace kill_me_maybe with kill_me_now in case
    > > the exception happened in user mode.
    >
    > Bah, I got confused, sorry about that - you're right.
    Well it is not the easiest code to decode 😊

    >
    > Btw, that kill_it should probably be called "kill_current_task" or so to
    > make it more clear.
    Sure I can add another patch to the set to rename it.

    Gab

    >
    > Thx.
    >
    > --
    > Regards/Gruss,
    > Boris.
    >
    > https://people.kernel.org/tglx/notes-about-netiquette
    ---------------------------------------------------------------------
    INTEL CORPORATION ITALIA S.p.A. con unico socio
    Sede: Milanofiori Palazzo E 4
    CAP 20094 Assago (MI)
    Capitale Sociale Euro 104.000,00 interamente versato
    Partita I.V.A. e Codice Fiscale 04236760155
    Repertorio Economico Amministrativo n. 997124
    Registro delle Imprese di Milano nr. 183983/5281/33
    Soggetta ad attivita' di direzione e coordinamento di
    INTEL CORPORATION, USA

    This e-mail and any attachments may contain confidential material for
    the sole use of the intended recipient(s). Any review or distribution
    by others is strictly prohibited. If you are not the intended
    recipient, please contact the sender and delete all copies.
    \
     
     \ /
      Last update: 2020-11-23 18:41    [W:3.267 / U:0.296 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site