lkml.org 
[lkml]   [2020]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/3] serial: 8250: of: Check for CONFIG_SERIAL_8250_BCM7271
On Fri, Nov 20, 2020 at 2:45 PM Al Cooper <alcooperx@gmail.com> wrote:
>
> From: Jim Quinlan <jquinlan@broadcom.com>
>
> This commit has of_platform_serial_probe() check specifically for the
> "brcm,bcm7271-uart" and whether its companion driver is enabled. If it
> is the case, and the clock provider is not ready, we want to make sure
> that when the 8250_bcm7271.c driver returns EPROBE_DEFER, we are not
> getting the UART registered via 8250_of.c.
>
> Signed-off-by: Jim Quinlan <jquinlan@broadcom.com>
> ---
> drivers/tty/serial/8250/8250_of.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/tty/serial/8250/8250_of.c b/drivers/tty/serial/8250/8250_of.c
> index 65e9045dafe6..aa458f3c6644 100644
> --- a/drivers/tty/serial/8250/8250_of.c
> +++ b/drivers/tty/serial/8250/8250_of.c
> @@ -192,6 +192,10 @@ static int of_platform_serial_probe(struct platform_device *ofdev)
> u32 tx_threshold;
> int ret;
>
> + if (IS_ENABLED(CONFIG_SERIAL_8250_BCM7271) &&
> + of_device_is_compatible(ofdev->dev.of_node, "brcm,bcm7271-uart"))
> + return -ENODEV;
> +
NOTE: this commit is a "strawman" commit, and I will not be surprised
if it gets quickly NAKed. We have a new idea on how to solve this
issue, and if that not is not viable, will ask for a dialog on this
problem either in this thread or through a separate RFC.

Regards,
Jim Quinlan
Broadcom STB



> port_type = (unsigned long)of_device_get_match_data(&ofdev->dev);
> if (port_type == PORT_UNKNOWN)
> return -EINVAL;
> --
> 2.17.1
>
[unhandled content-type:application/pkcs7-signature]
\
 
 \ /
  Last update: 2020-11-23 16:59    [W:0.169 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site