Messages in this thread | | | Date | Mon, 23 Nov 2020 14:39:54 +0000 | From | Quentin Perret <> | Subject | Re: [RFC PATCH 13/27] KVM: arm64: Enable access to sanitized CPU features at EL2 |
| |
On Monday 23 Nov 2020 at 13:22:23 (+0000), David Brazdil wrote: > Could you help my understand why we need this? > * Why do we need PI routines in the first place? Would my series that fixes > relocations in hyp code remove the need? > * You added these aliases for the string routines because you were worried > somebody would change the implementation in arch/arm64/lib, right? But this > cache flush function is defined in hyp/nvhe. So why do we need to point to > the PI alias if we control the implementation?
Right, in the specific case of the __flush_dcache_area() function none of the PI stuff is really needed I think. I did it this way to keep things as consistent as possible with the host-side implementation, but that is not required.
I understand this can cause confusion, so yes, I'll simplify this for v2.
Cheers, Quentin
| |