Messages in this thread |  | | Date | Sun, 22 Nov 2020 11:59:20 +0100 | From | Krzysztof Kozlowski <> | Subject | Re: [PATCH 01/38] ASoC: ak5558: drop of_match_ptr from of_device_id table |
| |
On Fri, Nov 20, 2020 at 08:04:29PM +0000, Mark Brown wrote: > On Fri, Nov 20, 2020 at 08:42:45PM +0100, Krzysztof Kozlowski wrote: > > On Fri, Nov 20, 2020 at 04:56:34PM +0000, Mark Brown wrote: > > > > It would be better to fix these by annotating the table as potentially > > > unused, if nothing else it means if someone wants to add ACPI support > > > (or it just works on their ACPI system with the plain old I2C ID) then > > > they don't need to revert this change. > > > The point is after this patch - removal of of_match_ptr() - they will > > already support the ACPI matching through the PRP0001. > > > Keeping of_match_ptr() and maybe_unused will prevent any ACPI re-usage > > unless explicit ACPI table is added > > Surely if that's the desired outcome the fix is to change the definition > of of_match_ptr() such that it leaves the reference with CONFIG_ACPI, > perhaps hidden behind a config option for PRP0001? That seems better > than going through the entire tree like this.
That could be indeed an easier way to achieve this.
+Cc Andy, Rafael,
I saw you were doing similar way as I did here [1] for the 698fffc2705c ("rtc: ds1307: Drop of_match_ptr and CONFIG_OF protections") with the same reasoning as mine ("These prevent use of this driver with ACPI via PRP0001.").
Do you have thoughts on Mark's proposal above (to change the of_match_ptr())?
[1] https://lore.kernel.org/lkml/20201120161653.445521-1-krzk@kernel.org/
Best regards, Krzysztof
|  |